[jira] (JETTY-1548) Jetty plug-in doesn't see overlays when invoked fromt the top-level project

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] (JETTY-1548) Jetty plug-in doesn't see overlays when invoked fromt the top-level project

JIRA jira@codehaus.org
Issue Type: Bug Bug
Affects Versions: 8.1.5
Assignee: Unassigned
Attachments: jetty-multi-module.zip
Components: Maven
Created: 08/Oct/12 12:16 PM
Description:

Please look at the attached file. There is a multi-module project, one module is a war, another is a Jar, containing a JUnit test that download a file served by the war. Jetty is started with such war in the jar module, before the test phase and by using the overlay mechanism (i.e., by listing the war as a dependency in the jar).

Everything works fine when I run 'mvn test' from the jar module. However, if I run the same maven command from the parent level (i.e., the pom-packaged project containing both modules), the test in the jar fails and it looks like the overlay is ignored.

Environment: Jetty plug-in 8.1.5.v20120716, 3.0.3 (r1075438; 2011-02-28 17:31:09+0000), Java 1.7.0_07, OS X 10.7.4
Project: Jetty
Labels: plugin maven-multi-module
Priority: Major Major
Reporter: Marco Brandizi
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Reply | Threaded
Open this post in threaded view
|

[jira] (JETTY-1548) Jetty plug-in doesn't see overlays when invoked fromt the top-level project

JIRA jira@codehaus.org
Change By: Joakim Erdfelt (08/Oct/12 1:10 PM)
Attachment: build.log
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Reply | Threaded
Open this post in threaded view
|

[jira] (JETTY-1548) Jetty plug-in doesn't see overlays when invoked fromt the top-level project

JIRA jira@codehaus.org
In reply to this post by JIRA jira@codehaus.org
Joakim Erdfelt commented on Bug JETTY-1548

No build problems encountered.

$ mvn clean install

Attaching build.log

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Reply | Threaded
Open this post in threaded view
|

[jira] (JETTY-1548) Jetty plug-in doesn't see overlays when invoked fromt the top-level project

JIRA jira@codehaus.org
In reply to this post by JIRA jira@codehaus.org
Marco Brandizi commented on Bug JETTY-1548

Actually It gives the described problem only when I do 'mvn test' from the top-level. 'mvn install' or 'package' works for me too. Maybe it's something with Maven life-cycles and goal-phase bindings?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Reply | Threaded
Open this post in threaded view
|

[jira] (JETTY-1548) Jetty plug-in doesn't see overlays when invoked fromt the top-level project

JIRA jira@codehaus.org
In reply to this post by JIRA jira@codehaus.org
Change By: Jan Bartel (15/Oct/12 2:57 AM)
Assignee: Jan Bartel
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Reply | Threaded
Open this post in threaded view
|

[jira] (JETTY-1548) Jetty plug-in doesn't see overlays when invoked fromt the top-level project

JIRA jira@codehaus.org
In reply to this post by JIRA jira@codehaus.org
Jan Bartel commented on Bug JETTY-1548

Hi Marco,

You're correct - when invoked from the top level of a multimodule build, the war artifact that is passed into the jetty plugin is actually the classes directory of the war artifact, not the built artifact.

In other words, the jetty-multi-web artifact is passed into the plugin as eg /home/janb/src/tmp/jetty-1548/multi-module/jetty-multi-web/target/classes and not /home/janb/.m2/repository/test/jetty-multi-web/0.0.1-SNAPSHOT/jetty-multi-web-0.0.1-SNAPSHOT.war

I guess this is because during a multimodule build, you're building all modules, including the war, up to and including the execution of the test phase, but not building the final artifact, so it can't be in the reactor.

However, when you're only executing the module that uses the jetty-maven-plugin (either by being in its directory and doing 'mvn test', or by being at the top level and doing 'mvn -pl :jetty-multi-cli') then maven will resolve the war artifact by looking in your local repo.

I can't think of anything that jetty could do to fix this, as this would seem to be the way that maven works. I'll have a look around some more documentation/ask around the maven dudes, but I can't see that much could be done about this ....

Jan

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Reply | Threaded
Open this post in threaded view
|

[jira] (JETTY-1548) Jetty plug-in doesn't see overlays when invoked fromt the top-level project

JIRA jira@codehaus.org
In reply to this post by JIRA jira@codehaus.org
Jan Bartel resolved Bug JETTY-1548 as Not A Bug

Marco,

Further to my last comments, I can't see anything that jetty can do about this - seems to be the way maven works. So I'm closing this issue for now. If you find a solution that jetty could implement, please open an issue over at Jetty's Eclipse bugzilla: https://bugs.eclipse.org/bugs/buglist.cgi?cmdtype=runnamed&namedcmd=jetty-bugs&list_id=3859349

Jan

Change By: Jan Bartel (13/Dec/12 10:01 PM)
Resolution: Not A Bug
Status: Open Resolved
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email