[jira] Created: (JETTY-796) Ant Plugin Improvements

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (JETTY-796) Ant Plugin Improvements

JIRA jira@codehaus.org
Ant Plugin Improvements
-----------------------

                 Key: JETTY-796
                 URL: http://jira.codehaus.org/browse/JETTY-796
             Project: Jetty
          Issue Type: Improvement
          Components: Maven2
    Affects Versions: 6.1.12.rc5
         Environment: I'm running ant 1.7.0 on Fedora 9.
            Reporter: Tony Strauss
         Attachments: build.xml

Following the instructions (http://docs.codehaus.org/display/JETTY/Ant+Jetty+Plugin), I've made jetty launch from my ant build file.  I run ant from the command-line, and I see several issues with the jetty/ant integration, although I may well be missing fixes for them:
1.) The Ant build does not fail if the Jetty server does not launch correctly
I've seen this if there already is a jetty server listening at the specified port.  In this case, the jetty task returns but the ant build ends successfully.

2.) The jetty server instance is not terminated when the plugin task returns to ant.  This causes jetty's termination trace to be mingled with ant's termination trace, which hides ant's termination status.  The trace below shows this:
     [echo] ============================================================
     [echo] ============================================================
     [echo] JETTY START-UP FAILED!
     [echo] There already be a Jetty running on the port!
     [echo] Check the log file!"
     [echo] ============================================================
     [echo] ============================================================

BUILD FAILED
/home/tony/working_copy/dict11/build.xml:792: JETTY FAILED

Total time: 8 seconds
2008-11-17 14:30:38.366::INFO:  Shutdown hook executing
2008-11-17 14:30:38.367:ptweb:INFO:  Destroying Spring FrameworkServlet 'main'
2008-11-17 14:30:38.371:ptweb:INFO:  Closing Spring root WebApplicationContext
2008-11-17 14:30:38.379:ptweb:INFO:  Shutting down log4j
log4j:WARN No appenders could be found for logger (com.mchange.v2.c3p0.impl.NewPooledConnection).
log4j:WARN Please initialize the log4j system properly.
2008-11-17 14:30:38.383::INFO:  Shutdown hook complete

I've attached the relevant part of my build file.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (JETTY-796) Ant Plugin Improvements

JIRA jira@codehaus.org

     [ http://jira.codehaus.org/browse/JETTY-796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jakub Pawlowicz reassigned JETTY-796:
-------------------------------------

    Assignee: Jakub Pawlowicz

> Ant Plugin Improvements
> -----------------------
>
>                 Key: JETTY-796
>                 URL: http://jira.codehaus.org/browse/JETTY-796
>             Project: Jetty
>          Issue Type: Improvement
>          Components: Maven2
>    Affects Versions: 6.1.12.rc5
>         Environment: I'm running ant 1.7.0 on Fedora 9.
>            Reporter: Tony Strauss
>            Assignee: Jakub Pawlowicz
>         Attachments: build.xml
>
>
> Following the instructions (http://docs.codehaus.org/display/JETTY/Ant+Jetty+Plugin), I've made jetty launch from my ant build file.  I run ant from the command-line, and I see several issues with the jetty/ant integration, although I may well be missing fixes for them:
> 1.) The Ant build does not fail if the Jetty server does not launch correctly
> I've seen this if there already is a jetty server listening at the specified port.  In this case, the jetty task returns but the ant build ends successfully.
> 2.) The jetty server instance is not terminated when the plugin task returns to ant.  This causes jetty's termination trace to be mingled with ant's termination trace, which hides ant's termination status.  The trace below shows this:
>      [echo] ============================================================
>      [echo] ============================================================
>      [echo] JETTY START-UP FAILED!
>      [echo] There already be a Jetty running on the port!
>      [echo] Check the log file!"
>      [echo] ============================================================
>      [echo] ============================================================
> BUILD FAILED
> /home/tony/working_copy/dict11/build.xml:792: JETTY FAILED
> Total time: 8 seconds
> 2008-11-17 14:30:38.366::INFO:  Shutdown hook executing
> 2008-11-17 14:30:38.367:ptweb:INFO:  Destroying Spring FrameworkServlet 'main'
> 2008-11-17 14:30:38.371:ptweb:INFO:  Closing Spring root WebApplicationContext
> 2008-11-17 14:30:38.379:ptweb:INFO:  Shutting down log4j
> log4j:WARN No appenders could be found for logger (com.mchange.v2.c3p0.impl.NewPooledConnection).
> log4j:WARN Please initialize the log4j system properly.
> 2008-11-17 14:30:38.383::INFO:  Shutdown hook complete
> I've attached the relevant part of my build file.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (JETTY-796) Ant Plugin Improvements

JIRA jira@codehaus.org
In reply to this post by JIRA jira@codehaus.org

    [ http://jira.codehaus.org/browse/JETTY-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=174416#action_174416 ]

Jason Porter commented on JETTY-796:
------------------------------------

I'd like to add the ability to fork the process that starts the server.  If I'm using ant as my primary build tool (and not an IDE) then I have to stop the server to recompile / repackage the application.  The scanning intervals is great, but it would be very helpful to be able to fork the process (and probably have a jettyStop task as well.

> Ant Plugin Improvements
> -----------------------
>
>                 Key: JETTY-796
>                 URL: http://jira.codehaus.org/browse/JETTY-796
>             Project: Jetty
>          Issue Type: Improvement
>          Components: Maven2
>    Affects Versions: 6.1.12.rc5
>         Environment: I'm running ant 1.7.0 on Fedora 9.
>            Reporter: Tony Strauss
>            Assignee: Jakub Pawlowicz
>         Attachments: build.xml
>
>
> Following the instructions (http://docs.codehaus.org/display/JETTY/Ant+Jetty+Plugin), I've made jetty launch from my ant build file.  I run ant from the command-line, and I see several issues with the jetty/ant integration, although I may well be missing fixes for them:
> 1.) The Ant build does not fail if the Jetty server does not launch correctly
> I've seen this if there already is a jetty server listening at the specified port.  In this case, the jetty task returns but the ant build ends successfully.
> 2.) The jetty server instance is not terminated when the plugin task returns to ant.  This causes jetty's termination trace to be mingled with ant's termination trace, which hides ant's termination status.  The trace below shows this:
>      [echo] ============================================================
>      [echo] ============================================================
>      [echo] JETTY START-UP FAILED!
>      [echo] There already be a Jetty running on the port!
>      [echo] Check the log file!"
>      [echo] ============================================================
>      [echo] ============================================================
> BUILD FAILED
> /home/tony/working_copy/dict11/build.xml:792: JETTY FAILED
> Total time: 8 seconds
> 2008-11-17 14:30:38.366::INFO:  Shutdown hook executing
> 2008-11-17 14:30:38.367:ptweb:INFO:  Destroying Spring FrameworkServlet 'main'
> 2008-11-17 14:30:38.371:ptweb:INFO:  Closing Spring root WebApplicationContext
> 2008-11-17 14:30:38.379:ptweb:INFO:  Shutting down log4j
> log4j:WARN No appenders could be found for logger (com.mchange.v2.c3p0.impl.NewPooledConnection).
> log4j:WARN Please initialize the log4j system properly.
> 2008-11-17 14:30:38.383::INFO:  Shutdown hook complete
> I've attached the relevant part of my build file.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (JETTY-796) Ant Plugin Improvements

JIRA jira@codehaus.org
In reply to this post by JIRA jira@codehaus.org

    [ https://jira.codehaus.org/browse/JETTY-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=280522#comment-280522 ]

Santthosh commented on JETTY-796:
---------------------------------

I am also really puzzled on how to stop the jetty (started using this plugin) gracefully... hasn't this been thought about in 2 years? Can someone guide me...

> Ant Plugin Improvements
> -----------------------
>
>                 Key: JETTY-796
>                 URL: https://jira.codehaus.org/browse/JETTY-796
>             Project: Jetty
>          Issue Type: Improvement
>          Components: Maven2
>    Affects Versions: 6.1.12.rc5
>         Environment: I'm running ant 1.7.0 on Fedora 9.
>            Reporter: Tony Strauss
>            Assignee: Jakub Pawlowicz
>         Attachments: build.xml
>
>
> Following the instructions (http://docs.codehaus.org/display/JETTY/Ant+Jetty+Plugin), I've made jetty launch from my ant build file.  I run ant from the command-line, and I see several issues with the jetty/ant integration, although I may well be missing fixes for them:
> 1.) The Ant build does not fail if the Jetty server does not launch correctly
> I've seen this if there already is a jetty server listening at the specified port.  In this case, the jetty task returns but the ant build ends successfully.
> 2.) The jetty server instance is not terminated when the plugin task returns to ant.  This causes jetty's termination trace to be mingled with ant's termination trace, which hides ant's termination status.  The trace below shows this:
>      [echo] ============================================================
>      [echo] ============================================================
>      [echo] JETTY START-UP FAILED!
>      [echo] There already be a Jetty running on the port!
>      [echo] Check the log file!"
>      [echo] ============================================================
>      [echo] ============================================================
> BUILD FAILED
> /home/tony/working_copy/dict11/build.xml:792: JETTY FAILED
> Total time: 8 seconds
> 2008-11-17 14:30:38.366::INFO:  Shutdown hook executing
> 2008-11-17 14:30:38.367:ptweb:INFO:  Destroying Spring FrameworkServlet 'main'
> 2008-11-17 14:30:38.371:ptweb:INFO:  Closing Spring root WebApplicationContext
> 2008-11-17 14:30:38.379:ptweb:INFO:  Shutting down log4j
> log4j:WARN No appenders could be found for logger (com.mchange.v2.c3p0.impl.NewPooledConnection).
> log4j:WARN Please initialize the log4j system properly.
> 2008-11-17 14:30:38.383::INFO:  Shutdown hook complete
> I've attached the relevant part of my build file.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply | Threaded
Open this post in threaded view
|

[jira] (JETTY-796) Ant Plugin Improvements

JIRA jira@codehaus.org
In reply to this post by JIRA jira@codehaus.org
Jan Bartel commented on Improvement JETTY-796

We will schedule any updates/improvements to jetty-ant for jetty-8, which should be in M0 release soon.

Jan

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Reply | Threaded
Open this post in threaded view
|

[jira] (JETTY-796) Ant Plugin Improvements

JIRA jira@codehaus.org
In reply to this post by JIRA jira@codehaus.org
 
Jan Bartel edited a comment on Improvement JETTY-796

We will schedule any updates/improvements to jetty-ant for jetty-9, which should be in M0 release soon.

Jan

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Reply | Threaded
Open this post in threaded view
|

[jira] (JETTY-796) Ant Plugin Improvements

JIRA jira@codehaus.org
In reply to this post by JIRA jira@codehaus.org
Change By: Jan Bartel (05/Dec/12 3:31 PM)
Assignee: Jakub Pawlowicz Jan Bartel
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
Reply | Threaded
Open this post in threaded view
|

[jira] (JETTY-796) Ant Plugin Improvements

JIRA jira@codehaus.org
In reply to this post by JIRA jira@codehaus.org
Jan Bartel resolved Improvement JETTY-796 as Fixed

Multiple updates done to jetty-ant plugin:

1. add jetty.stop task
2. renamed jetty task to jetty.run task
3. added attribute "daemon" which if true will cause the build to keep executing and jetty to execute in the background (NOT forked)
4. added stopPort and stopKey attributes to jetty.run to support jetty.stop task
5. added contextXml attribute to apply a context xml file to configure the webapp
6. changed webApp element to be a WebAppContext instance so attributes now are the setter methods from that class
7. works with jsp 2.2

Opened https://bugs.eclipse.org/bugs/show_bug.cgi?id=396012 to remind myself to document changes for jetty-9.

If there is interest in haveing a version that forks jetty in a new process, please open a new bug at Eclipse here: https://bugs.eclipse.org/bugs/buglist.cgi?cmdtype=runnamed&namedcmd=jetty-bugs&list_id=3781522

as jira is closed for new bugs.

thanks
Jan

Change By: Jan Bartel (06/Dec/12 11:34 PM)
Resolution: Fixed
Fix Version/s: 9.0.0
Status: Open Resolved
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email