[jira] Created: (JETTY-261) Jetty does not handle CONNECT method correctly

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (JETTY-261) Jetty does not handle CONNECT method correctly

JIRA jira@codehaus.org
Jetty does not handle CONNECT method correctly
----------------------------------------------

                 Key: JETTY-261
                 URL: http://jira.codehaus.org/browse/JETTY-261
             Project: Jetty
          Issue Type: Improvement
          Components: HTTP
    Affects Versions: 6.1.1
            Reporter: Anatoliy Salistra


While Jetty does not pretend to be a full-blown proxy server, correct handling of proxy requests is quite desirable. With ProxyServlet Jetty correctly handles HTTP proxy requests. However, HTTPS and CONNECT method fail even though ProxyServlet seems to be equipped to handle them. The problem arises earlier - in Request: it incorrectly parses CONNECT string. Unlike proxied GET of HTTP, CONNECT does not include the protocol for the target server. Browsers send "CONNECT mail.yahoo.com:443" rather than "CONNECT https://mail.yahoo.com". At this point HttpURI's parsing completely breaks down: it interpretes host as scheme, port as path etc.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
jetty-discuss mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jetty-discuss
Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (JETTY-261) Jetty does not handle CONNECT method correctly

JIRA jira@codehaus.org

     [ http://jira.codehaus.org/browse/JETTY-261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Greg Wilkins reassigned JETTY-261:
----------------------------------

    Assignee: Greg Wilkins

> Jetty does not handle CONNECT method correctly
> ----------------------------------------------
>
>                 Key: JETTY-261
>                 URL: http://jira.codehaus.org/browse/JETTY-261
>             Project: Jetty
>          Issue Type: Improvement
>          Components: HTTP
>    Affects Versions: 6.1.1
>            Reporter: Anatoliy Salistra
>         Assigned To: Greg Wilkins
>
> While Jetty does not pretend to be a full-blown proxy server, correct handling of proxy requests is quite desirable. With ProxyServlet Jetty correctly handles HTTP proxy requests. However, HTTPS and CONNECT method fail even though ProxyServlet seems to be equipped to handle them. The problem arises earlier - in Request: it incorrectly parses CONNECT string. Unlike proxied GET of HTTP, CONNECT does not include the protocol for the target server. Browsers send "CONNECT mail.yahoo.com:443" rather than "CONNECT https://mail.yahoo.com". At this point HttpURI's parsing completely breaks down: it interpretes host as scheme, port as path etc.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
jetty-discuss mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jetty-discuss
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (JETTY-261) Jetty does not handle CONNECT method correctly

JIRA jira@codehaus.org
In reply to this post by JIRA jira@codehaus.org

    [ http://jira.codehaus.org/browse/JETTY-261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_90423 ]

Greg Wilkins commented on JETTY-261:
------------------------------------

The Jetty 5 proxy Handler does correctly handle CONNECT

I don't think that CONNECT can be well handled within a servlet and the proxyservlet is really just an experiment.
We will soon be doing a Jetty 6 handler that will have full CONNECT capability.

watch this space....

> Jetty does not handle CONNECT method correctly
> ----------------------------------------------
>
>                 Key: JETTY-261
>                 URL: http://jira.codehaus.org/browse/JETTY-261
>             Project: Jetty
>          Issue Type: Improvement
>          Components: HTTP
>    Affects Versions: 6.1.1
>            Reporter: Anatoliy Salistra
>         Assigned To: Greg Wilkins
>
> While Jetty does not pretend to be a full-blown proxy server, correct handling of proxy requests is quite desirable. With ProxyServlet Jetty correctly handles HTTP proxy requests. However, HTTPS and CONNECT method fail even though ProxyServlet seems to be equipped to handle them. The problem arises earlier - in Request: it incorrectly parses CONNECT string. Unlike proxied GET of HTTP, CONNECT does not include the protocol for the target server. Browsers send "CONNECT mail.yahoo.com:443" rather than "CONNECT https://mail.yahoo.com". At this point HttpURI's parsing completely breaks down: it interpretes host as scheme, port as path etc.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
jetty-discuss mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jetty-discuss
Reply | Threaded
Open this post in threaded view
|

Re: [jira] Commented: (JETTY-261) Jetty does not handle CONNECT method correctly

Chris Haynes
I fairly urgently need Jetty to proxy HTTPS, and hence to handle CONNECT.  

My initial investigation suggests that Anatoliy may be right (see below): there seems to be a problem early in the server before a Servlet is even given a chance to respond (via the handle() API). I've not yet delved into the code.

The posting below from Greg in March implied it would be worked on soon.

Is anyone actively working on this, has it been fixed , or shall I have a look at it myself?

Chris Haynes



On Monday, March 19, 2007 at 1:05:34 AM, Greg Wilkins (JIRA) wrote:
>     [
> http://jira.codehaus.org/browse/JETTY-261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_90423 ]

> Greg Wilkins commented on JETTY-261:
> ------------------------------------

> The Jetty 5 proxy Handler does correctly handle CONNECT

> I don't think that CONNECT can be well handled within a servlet and
> the proxyservlet is really just an experiment.
> We will soon be doing a Jetty 6 handler that will have full CONNECT capability.

> watch this space....

>> Jetty does not handle CONNECT method correctly
>> ----------------------------------------------

>>                 Key: JETTY-261
>>                 URL: http://jira.codehaus.org/browse/JETTY-261
>>             Project: Jetty
>>          Issue Type: Improvement
>>          Components: HTTP
>>    Affects Versions: 6.1.1
>>            Reporter: Anatoliy Salistra
>>         Assigned To: Greg Wilkins

>> While Jetty does not pretend to be a full-blown proxy server, correct handling of proxy requests is quite desirable. With ProxyServlet Jetty correctly handles HTTP proxy requests. However, HTTPS and CONNECT method fail even though ProxyServlet seems to be equipped to handle them. The problem arises earlier - in Request: it incorrectly parses CONNECT string. Unlike proxied GET of HTTP, CONNECT does not include the protocol for the target server. Browsers send "CONNECT mail.yahoo.com:443" rather than "CONNECT https://mail.yahoo.com". At this point HttpURI's parsing completely breaks down: it interpretes host as scheme, port as path etc.


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
jetty-discuss mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jetty-discuss
Reply | Threaded
Open this post in threaded view
|

Re: [jira] Commented: (JETTY-261) Jetty does not handle CONNECT method correctly

Greg Wilkins
Chris Haynes wrote:

> I fairly urgently need Jetty to proxy HTTPS, and hence to handle CONNECT.  
>
> My initial investigation suggests that Anatoliy may be right (see below): there seems to be a problem early in the server before a Servlet is even given a chance to respond (via the handle() API). I've not yet delved into the code.
>
> The posting below from Greg in March implied it would be worked on soon.
>
> Is anyone actively working on this, has it been fixed , or shall I have a look at it myself?
>
> Chris Haynes
>

Chris,

Well I have been promising this for a long long time.   With some help a few
months ago, we got the proxy code in Jetty-6 close to working.  But then my
available free time evaporated!

So I have to continue to promise that I will address it soon.

Any help making the non-blocking client API work will be on the critical
path to considering CONNECT support.

cheers



--
Greg Wilkins<[hidden email]>                       US:  +1  3104915462
http://www.webtide.com           UK: +44(0)2079932589 AU: +61(0)417786631

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
jetty-discuss mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jetty-discuss
Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (JETTY-261) Jetty does not handle CONNECT method correctly

JIRA jira@codehaus.org
In reply to this post by JIRA jira@codehaus.org

     [ http://jira.codehaus.org/browse/JETTY-261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Greg Wilkins closed JETTY-261.
------------------------------

    Resolution: Duplicate

> Jetty does not handle CONNECT method correctly
> ----------------------------------------------
>
>                 Key: JETTY-261
>                 URL: http://jira.codehaus.org/browse/JETTY-261
>             Project: Jetty
>          Issue Type: Improvement
>          Components: HTTP
>    Affects Versions: 6.1.1
>            Reporter: Anatoliy Salistra
>            Assignee: Greg Wilkins
>
> While Jetty does not pretend to be a full-blown proxy server, correct handling of proxy requests is quite desirable. With ProxyServlet Jetty correctly handles HTTP proxy requests. However, HTTPS and CONNECT method fail even though ProxyServlet seems to be equipped to handle them. The problem arises earlier - in Request: it incorrectly parses CONNECT string. Unlike proxied GET of HTTP, CONNECT does not include the protocol for the target server. Browsers send "CONNECT mail.yahoo.com:443" rather than "CONNECT https://mail.yahoo.com". At this point HttpURI's parsing completely breaks down: it interpretes host as scheme, port as path etc.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
jetty-discuss mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/jetty-discuss