[jetty-dev] thoughts on java module dependencies

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[jetty-dev] thoughts on java module dependencies

Raymond Auge
Hey folks,

I was wondering if there were any thoughts about cleaning up post Java 9 dependencies?

The idea being to be able to target smaller JVM profiles via jlink.

Given this minimal set:
jetty-http-9.4.12.v20180830.jar
jetty-io-9.4.12.v20180830.jar
jetty-security-9.4.12.v20180830.jar
jetty-server-9.4.12.v20180830.jar
jetty-servlet-9.4.12.v20180830.jar
jetty-util-9.4.12.v20180830.jar

There are a few very light usages that cause things like `java.desktop` to be dragged in:

jetty-servlet-9.4.12.v20180830.jar -> java.desktop
   org.eclipse.jetty.servlet.listener.IntrospectorCleaner -> java.beans.Introspector                            java.desktop
jetty-util-9.4.12.v20180830.jar -> java.desktop
   org.eclipse.jetty.util.preventers.AWTLeakPreventer -> java.awt.Toolkit                                   java.desktop
   org.eclipse.jetty.util.preventers.AppContextLeakPreventer -> javax.imageio.ImageIO                              java.desktop

There are others that would be nice to clean up, but eliminating java.desktop dependency is really the major one.

Thoughts?

--
Raymond Augé (@rotty3000)
Senior Software Architect Liferay, Inc. (@Liferay)
Board Member & EEG Co-Chair, OSGi Alliance (@OSGiAlliance)

_______________________________________________
jetty-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-dev
Reply | Threaded
Open this post in threaded view
|

Re: [jetty-dev] thoughts on java module dependencies

Simone Bordet-3
Hi,

On Mon, Feb 25, 2019 at 9:14 PM Raymond Auge <[hidden email]> wrote:

>
> Hey folks,
>
> I was wondering if there were any thoughts about cleaning up post Java 9 dependencies?
>
> The idea being to be able to target smaller JVM profiles via jlink.
>
> Given this minimal set:
> jetty-http-9.4.12.v20180830.jar
> jetty-io-9.4.12.v20180830.jar
> jetty-security-9.4.12.v20180830.jar
> jetty-server-9.4.12.v20180830.jar
> jetty-servlet-9.4.12.v20180830.jar
> jetty-util-9.4.12.v20180830.jar
>
> There are a few very light usages that cause things like `java.desktop` to be dragged in:
>
> jetty-servlet-9.4.12.v20180830.jar -> java.desktop
>    org.eclipse.jetty.servlet.listener.IntrospectorCleaner -> java.beans.Introspector                            java.desktop
> jetty-util-9.4.12.v20180830.jar -> java.desktop
>    org.eclipse.jetty.util.preventers.AWTLeakPreventer -> java.awt.Toolkit                                   java.desktop
>    org.eclipse.jetty.util.preventers.AppContextLeakPreventer -> javax.imageio.ImageIO                              java.desktop
>
> There are others that would be nice to clean up, but eliminating java.desktop dependency is really the major one.

We have cleaned up this in Jetty 10, where we require Java 11 and we
use proper JPMS module-info.java files.
Would that suffice?

--
Simone Bordet
----
http://cometd.org
http://webtide.com
Developer advice, training, services and support
from the Jetty & CometD experts.
_______________________________________________
jetty-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-dev
Reply | Threaded
Open this post in threaded view
|

Re: [jetty-dev] thoughts on java module dependencies

Raymond Auge


On Mon, Feb 25, 2019, 15:49 Simone Bordet, <[hidden email]> wrote:
Hi,

On Mon, Feb 25, 2019 at 9:14 PM Raymond Auge <[hidden email]> wrote:
>
> Hey folks,
>
> I was wondering if there were any thoughts about cleaning up post Java 9 dependencies?
>
> The idea being to be able to target smaller JVM profiles via jlink.
>
> Given this minimal set:
> jetty-http-9.4.12.v20180830.jar
> jetty-io-9.4.12.v20180830.jar
> jetty-security-9.4.12.v20180830.jar
> jetty-server-9.4.12.v20180830.jar
> jetty-servlet-9.4.12.v20180830.jar
> jetty-util-9.4.12.v20180830.jar
>
> There are a few very light usages that cause things like `java.desktop` to be dragged in:
>
> jetty-servlet-9.4.12.v20180830.jar -> java.desktop
>    org.eclipse.jetty.servlet.listener.IntrospectorCleaner -> java.beans.Introspector                            java.desktop
> jetty-util-9.4.12.v20180830.jar -> java.desktop
>    org.eclipse.jetty.util.preventers.AWTLeakPreventer -> java.awt.Toolkit                                   java.desktop
>    org.eclipse.jetty.util.preventers.AppContextLeakPreventer -> javax.imageio.ImageIO                              java.desktop
>
> There are others that would be nice to clean up, but eliminating java.desktop dependency is really the major one.

We have cleaned up this in Jetty 10, where we require Java 11 and we
use proper JPMS module-info.java files.
Would that suffice?

Got it! Yeah, that would probably do it.

I'll take a look.

Thanks,
- Ray


--
Simone Bordet
----
http://cometd.org
http://webtide.com
Developer advice, training, services and support
from the Jetty & CometD experts.
_______________________________________________
jetty-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-dev

_______________________________________________
jetty-dev mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-dev