Why does push request contain query string?

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Why does push request contain query string?

John Jiang
Hi,
I'm using Jetty 10.0.0-alpha0
Please consider this case:
1. Client sends request for the below url,
http://host:port/push?query
2. Server pushes some resources, including img1, img2.
The push requests look like the followings,
http://host:port/img1?query
http://host:port/img2?query

Does it make sense that the query string is always in the push requests?

Thanks!

_______________________________________________
jetty-users mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-users
Reply | Threaded
Open this post in threaded view
|

Re: Why does push request contain query string?

Simone Bordet-3
Hi,

On Mon, Sep 16, 2019 at 5:26 PM John Jiang <[hidden email]> wrote:

>
> Hi,
> I'm using Jetty 10.0.0-alpha0
> Please consider this case:
> 1. Client sends request for the below url,
> <a href="http://host:port/push?query">http://host:port/push?query
> 2. Server pushes some resources, including img1, img2.
> The push requests look like the followings,
> <a href="http://host:port/img1?query">http://host:port/img1?query
> <a href="http://host:port/img2?query">http://host:port/img2?query
>
> Does it make sense that the query string is always in the push requests?

That does not look right.
Can you please open an issue about this?

--
Simone Bordet
----
http://cometd.org
http://webtide.com
Developer advice, training, services and support
from the Jetty & CometD experts.
_______________________________________________
jetty-users mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-users
Reply | Threaded
Open this post in threaded view
|

Re: Why does push request contain query string?

Greg Wilkins
The PushBuilder is initialized with all the headers and query string of  the existing request.   You have to reset the query string if you don't want it.   This looks deliberate in the code.... but need to check if it really is intended by the spec.

On Tue, 17 Sep 2019 at 01:58, Simone Bordet <[hidden email]> wrote:
Hi,

On Mon, Sep 16, 2019 at 5:26 PM John Jiang <[hidden email]> wrote:
>
> Hi,
> I'm using Jetty 10.0.0-alpha0
> Please consider this case:
> 1. Client sends request for the below url,
> http://host:port/push?query
> 2. Server pushes some resources, including img1, img2.
> The push requests look like the followings,
> http://host:port/img1?query
> http://host:port/img2?query
>
> Does it make sense that the query string is always in the push requests?

That does not look right.
Can you please open an issue about this?

--
Simone Bordet
----
http://cometd.org
http://webtide.com
Developer advice, training, services and support
from the Jetty & CometD experts.
_______________________________________________
jetty-users mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-users


--

_______________________________________________
jetty-users mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-users
Reply | Threaded
Open this post in threaded view
|

Re: Why does push request contain query string?

Greg Wilkins
The spec for pushbuilder in 4.0 says that it will be initialized with the query string:


On Tue, 17 Sep 2019 at 09:26, Greg Wilkins <[hidden email]> wrote:
The PushBuilder is initialized with all the headers and query string of  the existing request.   You have to reset the query string if you don't want it.   This looks deliberate in the code.... but need to check if it really is intended by the spec.

On Tue, 17 Sep 2019 at 01:58, Simone Bordet <[hidden email]> wrote:
Hi,

On Mon, Sep 16, 2019 at 5:26 PM John Jiang <[hidden email]> wrote:
>
> Hi,
> I'm using Jetty 10.0.0-alpha0
> Please consider this case:
> 1. Client sends request for the below url,
> http://host:port/push?query
> 2. Server pushes some resources, including img1, img2.
> The push requests look like the followings,
> http://host:port/img1?query
> http://host:port/img2?query
>
> Does it make sense that the query string is always in the push requests?

That does not look right.
Can you please open an issue about this?

--
Simone Bordet
----
http://cometd.org
http://webtide.com
Developer advice, training, services and support
from the Jetty & CometD experts.
_______________________________________________
jetty-users mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-users


--


--

_______________________________________________
jetty-users mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-users
Reply | Threaded
Open this post in threaded view
|

Re: Why does push request contain query string?

John Jiang
Got it, thanks!

On Tue, Sep 17, 2019 at 7:32 AM Greg Wilkins <[hidden email]> wrote:
The spec for pushbuilder in 4.0 says that it will be initialized with the query string:


On Tue, 17 Sep 2019 at 09:26, Greg Wilkins <[hidden email]> wrote:
The PushBuilder is initialized with all the headers and query string of  the existing request.   You have to reset the query string if you don't want it.   This looks deliberate in the code.... but need to check if it really is intended by the spec.

On Tue, 17 Sep 2019 at 01:58, Simone Bordet <[hidden email]> wrote:
Hi,

On Mon, Sep 16, 2019 at 5:26 PM John Jiang <[hidden email]> wrote:
>
> Hi,
> I'm using Jetty 10.0.0-alpha0
> Please consider this case:
> 1. Client sends request for the below url,
> http://host:port/push?query
> 2. Server pushes some resources, including img1, img2.
> The push requests look like the followings,
> http://host:port/img1?query
> http://host:port/img2?query
>
> Does it make sense that the query string is always in the push requests?

That does not look right.
Can you please open an issue about this?

--
Simone Bordet
----
http://cometd.org
http://webtide.com
Developer advice, training, services and support
from the Jetty & CometD experts.
_______________________________________________
jetty-users mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-users


--


--
_______________________________________________
jetty-users mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-users

_______________________________________________
jetty-users mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-users