Jetty 9.4.21 regression in Listener calls made

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Jetty 9.4.21 regression in Listener calls made

John Gardiner Myers
After upgrading from Jetty 9.4.20 to 9.4.21, one of my regression tests
is failing.

I have tracked this down to a test where I create an embedded Jetty
server and client, enabling h2c on both (HTTPS is not configured), and
doing a simple GET request, with no body, from the client to the server.
The org.eclipse.jetty.server.HttpChannel.Listener I installed into the
server is getting onRequestEnd(Request) called without its
onRequestBegin(request) having been previously called.

Is this enough information, or would you need me to construct a reduced
test case?

(And I noticed that 9.4.21 is, for HTTP/1.1, no longer passing through
the HTTP status message returned from the servlet or HTTP server.)


_______________________________________________
jetty-users mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-users
Reply | Threaded
Open this post in threaded view
|

Re: Jetty 9.4.21 regression in Listener calls made

Simone Bordet-3
John,

On Wed, Oct 2, 2019 at 12:52 AM John Gardiner Myers
<[hidden email]> wrote:

>
> After upgrading from Jetty 9.4.20 to 9.4.21, one of my regression tests
> is failing.
>
> I have tracked this down to a test where I create an embedded Jetty
> server and client, enabling h2c on both (HTTPS is not configured), and
> doing a simple GET request, with no body, from the client to the server.
> The org.eclipse.jetty.server.HttpChannel.Listener I installed into the
> server is getting onRequestEnd(Request) called without its
> onRequestBegin(request) having been previously called.
>
> Is this enough information, or would you need me to construct a reduced
> test case?

Please open an issue and if you can a test case would be greatly appreciated.

> (And I noticed that 9.4.21 is, for HTTP/1.1, no longer passing through
> the HTTP status message returned from the servlet or HTTP server.)

Not sure I understand this one?

--
Simone Bordet
----
http://cometd.org
http://webtide.com
Developer advice, training, services and support
from the Jetty & CometD experts.
_______________________________________________
jetty-users mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-users
Reply | Threaded
Open this post in threaded view
|

Re: Jetty 9.4.21 regression in Listener calls made

Greg Wilkins
John,

yes please for the test case.  But can you also tell us in the meantime how you are creating and adding the listener?

regards

On Tue, 15 Oct 2019 at 20:42, Simone Bordet <[hidden email]> wrote:
John,

On Wed, Oct 2, 2019 at 12:52 AM John Gardiner Myers
<[hidden email]> wrote:
>
> After upgrading from Jetty 9.4.20 to 9.4.21, one of my regression tests
> is failing.
>
> I have tracked this down to a test where I create an embedded Jetty
> server and client, enabling h2c on both (HTTPS is not configured), and
> doing a simple GET request, with no body, from the client to the server.
> The org.eclipse.jetty.server.HttpChannel.Listener I installed into the
> server is getting onRequestEnd(Request) called without its
> onRequestBegin(request) having been previously called.
>
> Is this enough information, or would you need me to construct a reduced
> test case?

Please open an issue and if you can a test case would be greatly appreciated.

> (And I noticed that 9.4.21 is, for HTTP/1.1, no longer passing through
> the HTTP status message returned from the servlet or HTTP server.)

Not sure I understand this one?

--
Simone Bordet
----
http://cometd.org
http://webtide.com
Developer advice, training, services and support
from the Jetty & CometD experts.
_______________________________________________
jetty-users mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-users


--

_______________________________________________
jetty-users mailing list
[hidden email]
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-users